feat(rome_js_parser): instantiation expressions #3147

[denbezrukov]

Summary

This PR fixes:
#3793
#3147

When a potential type argument list is followed by

• a line break,
• an ( token,
• a template literal string, or
• any token except < or > that isn't the start of an expression,

Typescript reference:

• https://github.com/microsoft/TypeScript/blob/212d3864ef08a78454b2a12f7e1f11789917440e/src/compiler/parser.ts#L6394-L6413

Typescript design notes:

• Design Meeting Notes, 6/3/2022 microsoft/TypeScript#49384
• Design Meeting Notes, 6/8/2022 microsoft/TypeScript#49444

Relative issues:

• Instantiation expression can be followed by line break or binary operator microsoft/TypeScript#49353
• Instantiation expressions not allowed in logical/coalescing expressions microsoft/TypeScript#49362
• [ts] Add support for instantiation expressions babel/babel#14457
• Make TS InstantiationExpr parsing more permissive evanw/esbuild#2188

Open questions:

• Typescript has an extra condition in isBinaryOperator function: https://github.com/microsoft/TypeScript/blob/main/src/compiler/parser.ts#L5528-L5534
• Typescript and babel dissalow expression with type parameters as left side of property access Prettier playground:
  Disallow expression with type parameters as left side of property access microsoft/TypeScript#49464
  [ts] Disallow property access after instantiation expression babel/babel#14650
• f<T> << f<T>; is valid code. But this PR doesn't support it. May be we can do it in another PR. Prettier playground

Test Plan

cargo test -p rome_js_parser

test cases from babel:

• https://github.com/babel/babel/tree/main/packages/babel-parser/test/fixtures/typescript/type-arguments/instantiation-expression-asi
• https://github.com/babel/babel/tree/main/packages/babel-parser/test/fixtures/typescript/type-arguments/instantiation-expression-binary-operator
• https://github.com/babel/babel/tree/main/packages/babel-parser/test/fixtures/typescript/type-arguments/instantiation-expression-false-positive-2
• https://github.com/babel/babel/tree/main/packages/babel-parser/test/fixtures/typescript/type-arguments/instantiation-expression-false-positive-3
• https://github.com/babel/babel/tree/main/packages/babel-parser/test/fixtures/typescript/type-arguments/instantiation-expression-false-positive-4
• https://github.com/babel/babel/tree/main/packages/babel-parser/test/fixtures/typescript/type-arguments/instantiation-expression-false-positive
• https://github.com/babel/babel/tree/main/packages/babel-parser/test/fixtures/typescript/type-arguments/instantiation-expression-optional-chain
• https://github.com/babel/babel/tree/main/packages/babel-parser/test/fixtures/typescript/type-arguments/instantiation-expression-property-access
• https://github.com/babel/babel/tree/main/packages/babel-parser/test/fixtures/typescript/type-arguments/instantiation-expression

test cases from esbuild:

• https://github.com/evanw/esbuild/blob/895f50c84b47f2506c02b74972da9640db800c54/internal/js_parser/ts_parser_test.go#L1916

[netlify]

✅ Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name	Link
🔨 Latest commit	2b69507
🔍 Latest deploy log	https://app.netlify.com/sites/docs-rometools/deploys/639c15ee0a9ac0000805f32a

[MichaReiser]

Let's rebase this PR to get the latest parser conformance tests. This PR should fix some of them.

[MichaReiser]

I ran the typescript instantiation expression tests and there's one test that is passing when it should not:

• [FAIL] type-arguments\instantiation-expression-property-access: Incorrectly passed

The test should fail because it's invalid to access a property after an instantiation expression.

// invalid
a<b>.c;
a<b>?.c;
a<b>?.[c];

I assume that TypeScript implements this as part of the type checker and not as part of the parser itself (but it would be worth double-checking).

We have two options if that's the case:

• Try to implement it as part of the parser
• Implement a syntax rule that reports property accessors after instantiation expressions

And we can implement this either as part of this or a separate PR. Let me know what you prefer.

[denbezrukov]

Babel ts parser and typescript parser have a different implementation about access a property after an instantiation expression.

• Disallow expression with type parameters as left side of property access microsoft/TypeScript#49464
• [ts] Disallow property access after instantiation expression babel/babel#14650

We want to have the same behaviour as typescript parser. Typescript playground

Added new test cases and an error.

[MichaReiser]

Thank you so much for working on this. Well done! 🥳