Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_service): add extends functionality #4572

Merged
merged 5 commits into from
Jun 23, 2023

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented Jun 15, 2023

Summary

Closes #4038

This PR introduces breaking changes, mainly how the CLI handles broken configurations.

Before, a broken configuration would have resulted in warnings and Rome applying its defaults for the broken sections. I realised that while this is "cool", this isn't ideal for users because this would result in the following:

  • false positives while running the linter
  • incorrect formatting, with a configuration that isn't the one of the users

That's a breaking change.

Plus, now the rome check command shows diagnostics that belong to the formatter too.

Test Plan

Added some test cases

Changelog

  • The PR requires a changelog line

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit 2171857
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6495a6a262d30000082cafe1

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project configuration and loading labels Jun 15, 2023
@ematipico ematipico force-pushed the feat/configuration-extends branch from bc82d12 to 1f7ec40 Compare June 17, 2023 13:04
@github-actions github-actions bot added A-Core Area: core A-LSP Area: language server protocol labels Jun 17, 2023
@ematipico ematipico force-pushed the feat/configuration-extends branch from 024a1a6 to 1fd1df2 Compare June 19, 2023 07:44
@ematipico ematipico force-pushed the feat/configuration-extends branch from 1fd1df2 to 87f3f2c Compare June 22, 2023 10:08
@ematipico ematipico force-pushed the feat/configuration-extends branch 5 times, most recently from d9c670a to a4e9082 Compare June 22, 2023 10:56
@ematipico ematipico marked this pull request as ready for review June 22, 2023 11:01
@ematipico ematipico force-pushed the feat/configuration-extends branch from a4e9082 to 2171857 Compare June 23, 2023 14:05
@ematipico ematipico merged commit ab1784a into main Jun 23, 2023
@ematipico ematipico deleted the feat/configuration-extends branch June 23, 2023 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-CLI Area: CLI A-Core Area: core A-LSP Area: language server protocol A-Project Area: project configuration and loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Support extensible config via "extends" property
2 participants