This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_service): add extends
functionality
#4572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4038
This PR introduces breaking changes, mainly how the CLI handles broken configurations.
Before, a broken configuration would have resulted in warnings and Rome applying its defaults for the broken sections. I realised that while this is "cool", this isn't ideal for users because this would result in the following:
That's a breaking change.
Plus, now the
rome check
command shows diagnostics that belong to the formatter too.Test Plan
Added some test cases
Changelog
Documentation