Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_service, rome_js_parser): add parse options #4587

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented Jun 17, 2023

Summary

Closes #4586

This one took a bit because we use the parse functions in many places. I preferred to keep the current functions because I wanted to keep the exposed API to a minimum

cc @denbezrukov

Test Plan

Current tests should pass

Changelog

  • The PR requires a changelog line

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Jun 17, 2023

Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit de3f1b1
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6490144b63108d00089b551e

@github-actions github-actions bot added A-Parser Area: parser A-Project Area: project configuration and loading A-Formatter Area: formatter A-Linter Area: linter A-Tooling Area: our own build, development, and release tooling labels Jun 17, 2023
@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 48863 48863 0
Passed 47810 47810 0
Failed 1053 1053 0
Panics 0 0 0
Coverage 97.84% 97.84% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6212 6212 0
Passed 1763 1763 0
Failed 4449 4449 0
Panics 0 0 0
Coverage 28.38% 28.38% 0.00%

ts/babel

Test result main count This PR count Difference
Total 639 639 0
Passed 573 573 0
Failed 66 66 0
Panics 0 0 0
Coverage 89.67% 89.67% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17224 17224 0
Passed 13121 13121 0
Failed 4103 4103 0
Panics 0 0 0
Coverage 76.18% 76.18% 0.00%

@ematipico ematipico force-pushed the feat/parser-options branch from 57c0410 to de3f1b1 Compare June 19, 2023 08:39
@ematipico ematipico requested a review from denbezrukov June 19, 2023 09:29
@ematipico ematipico merged commit a34cdcc into main Jun 20, 2023
@ematipico ematipico deleted the feat/parser-options branch June 20, 2023 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Formatter Area: formatter A-Linter Area: linter A-Parser Area: parser A-Project Area: project configuration and loading A-Tooling Area: our own build, development, and release tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update parse functions to accept new options
2 participants