This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_formatter): Use custom trait for unique LabelIds
#4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
MichaReiser
commented
Jun 21, 2023
crates/rome_js_formatter/src/lib.rs
Outdated
| @@ -196,143 +197,7 @@ use crate::context::{JsFormatContext, JsFormatOptions}; | |||
| use crate::cst::FormatJsSyntaxNode; | |||
| use crate::syntax_rewriter::transform; | |||
|
|
|||
| /// Used to get an object that knows how to format this object. | |||
There was a problem hiding this comment.
This is unrelated to the change. Happy to undo. But we should either remove the shared_traits.rs file or include it.
There was a problem hiding this comment.
Probably, we want to remove the file and keep the code.
This code would fail when publishing the crate, I think.
There was a problem hiding this comment.
Okay. I'll undo
MichaReiser
force-pushed
the
replace-typeid-for-label-with-trait
branch
from
9c012b6 to
a5243d4
Compare
ematipico
approved these changes
Jun 22, 2023
Signed-off-by: Micha Reiser <micha@reiser.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See astral-sh/ruff#5263
Rust 1.72.0 changes
TypeIdfrom au64to au128. This breaks Rome's release build because it increases the size ofFormatElement.This PR removes the dependency on
TypeIdforLabelIdand instead introduces a new trait that downstream crates should implement on anenumdefining all labels for that project.This approach has two downsides:
Label. Mixing twoLabelcould result in two labels being equal that should not be equal. I added adebug assertion that compares the names of the labels to mitigate the risk.
Labelrequires more boilerplate code than beforeOne main upside is that it allows a project to define all labels in a single place (and search for all label usages).
Test Plan
cargo testandcargo build --release -p rome_formatterwith Rust 1.72.0Changelog
Documentation