This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
chore: add more cases to noSelfAssign
#4672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for docs-rometools failed.
|
ematipico
commented
Jul 9, 2023
| @@ -318,8 +327,15 @@ impl SameIdentifiers { | |||
| )) | |||
| .is_some() | |||
| { | |||
| return Some(AnyAssignmentLike::Identifiers(identifier_like)); | |||
| let source_identifier = IdentifiersLike::try_from(( | |||
There was a problem hiding this comment.
There was a bug where the rule wasn't flagging the "last" identifier of the assignment expression.
Now the rule, in a case like a.b.c = a.b.c; correctly highlights c.
Conaclos
approved these changes
Jul 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3980
I added more coverage to the cases deemed invalid.
Test Plan
I added more test cases.