This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 657
feat(rome_formatter): add support to format comments #4718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
A-Formatter
Area: formatter
A-CLI
Area: CLI
A-Parser
Area: parser
A-Project
Area: project configuration and loading
labels
Jul 21, 2023
denbezrukov
reviewed
Jul 21, 2023
denbezrukov
reviewed
Jul 21, 2023
denbezrukov
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did it so fast!
Keep up the fantastic work!
github-actions
bot
added
A-Website
Area: website and documentation
A-Core
Area: core
L-JavaScript
Langauge: JavaScript
L-JSON
Language: JSON
labels
Jul 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-CLI
Area: CLI
A-Core
Area: core
A-Formatter
Area: formatter
A-Parser
Area: parser
A-Project
Area: project configuration and loading
A-Website
Area: website and documentation
L-JavaScript
Langauge: JavaScript
L-JSON
Language: JSON
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's here! Added support to format comments inside JSON files :)
Test Plan
Added new tests