Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

refactor(rome_js_analyze): improve useEnumInitializers #4733

Merged
merged 1 commit into from
Jul 30, 2023
Merged

refactor(rome_js_analyze): improve useEnumInitializers #4733

merged 1 commit into from
Jul 30, 2023

Conversation

Conaclos
Copy link
Contributor

Summary

The rule now reports all uninitialized members of an enum in a single diagnostic.
This reduces the noise produced by the rule.
This also simplifies the implementation of the quick-fix.

Moreover, ambient enum declarations are now ignored.
This avoids reporting ambient enum declarations in TypeScript declaration files.

declare enum Weather {
  Rainy,
  Sunny,
}

Test Plan

New tests included.

@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 8209818
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64c638d5401b020008f2146e

@github-actions github-actions bot added A-Website Area: website and documentation A-Linter Area: linter L-JavaScript Langauge: JavaScript labels Jul 28, 2023
@Conaclos Conaclos requested a review from ematipico July 28, 2023 13:10
CHANGELOG.md Outdated Show resolved Hide resolved
@Conaclos Conaclos merged commit 675b8ed into rome:main Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter A-Website Area: website and documentation L-JavaScript Langauge: JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants