This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_js_analyze): improve useEnumInitializers
#4733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The rule now reports all uninitialized members of an enum in a single diagnostic.
This reduces the noise produced by the rule.
This also simplifies the implementation of the quick-fix.
Moreover, ambient enum declarations are now ignored.
This avoids reporting ambient enum declarations in TypeScript declaration files.
Test Plan
New tests included.