Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect workingDirectory on extracting git changed files #70

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Seitk
Copy link

@Seitk Seitk commented Sep 22, 2023

The current filter-changed-files does not work with monorepo (see issue here)

The reason behind is that:

  • jest test is usually under subfolder like packages/a, and the coverage will be generated along in the root directory of jest by default
  • The file change detection based on git, which will be in the root of the git repo
  • Such that the file path in test coverage file will never matches the file path in git compare

There are different ways to fix but the most intuitive one will be respecting the working directory we set in the GitHub action config when we get the changed file names from git compare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant