Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jdom2 XXE injection vulnerability #469

Closed
ethauvin opened this issue Jun 16, 2021 · 6 comments
Closed

Jdom2 XXE injection vulnerability #469

ethauvin opened this issue Jun 16, 2021 · 6 comments

Comments

@ethauvin
Copy link

jdom2 is vulnerable to XML External Entity (XXE) Injection. See:

jdom2 will most likely not be updated, an alternative should be found as already suggested in #455

@PatrickGotthard
Copy link
Member

We disallow Doctype declarations by default. So this is only an issuewhen someone enables Doctype declarations.

@j-be
Copy link

j-be commented Jul 5, 2021

@PatrickGotthard Would you mind going into more detail on how somebody would enable Doctype declarations in Rome, so we could check if we do (on purpose or by error)?

@PatrickGotthard
Copy link
Member

PatrickGotthard commented Jul 5, 2021

Have a look at #203
You have to call setAllowDoctypes(true) on SyndFeedInput to allow Doctype declarations.

@j-be
Copy link

j-be commented Jul 5, 2021

@PatrickGotthard Thanks for the clarification. That only applies when reading feeds, right? Are there any risks involved when creating feeds, e.g. disclosing files via:

<?xml  version="1.0" encoding="ISO-8859-1"?>
<!DOCTYPE foo [
   <!ELEMENT foo ANY >
   <!ENTITY xxe SYSTEM  "file:///etc/passwd" >]>
<foo>&xxe;</foo>

@PatrickGotthard
Copy link
Member

Only when you create an XML bomb yourself and consume it yourself afterwards :D

@PatrickGotthard
Copy link
Member

I've fixed the security issue and published version 1.16.0
It should be available in Maven Central soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants