Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(value): say that we can convert number to g(u)int64 #301

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

peat-psuwit
Copy link
Contributor

We already has support for it in V8ToGValue() and vice versa, so it's a
bug that CanConvertV8ToGValue() says that we cannot.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We already has support for it in V8ToGValue() and vice versa, so it's a
bug that CanConvertV8ToGValue() says that we cannot.
@romgrk
Copy link
Owner

romgrk commented Aug 1, 2021

Thanks, sorry for the delay.

@romgrk romgrk merged commit 30d60f2 into romgrk:master Aug 1, 2021
@TeaSeaLancs
Copy link

Hi, will there be a versioned release with this fix in soon? It's a fairly critical blocker to adoption of version 0.9.0.

@romgrk
Copy link
Owner

romgrk commented Sep 28, 2021

@TeaSeaLancs I've published a minor release just now from master. Give it an hour or two to finish building pre-built binaries and it should be usabled. Let me know if there is any issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants