Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added async docker segment to display number of running, paused and … #1290

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

git-rz
Copy link

@git-rz git-rz commented Mar 8, 2021

…exited containers.

Also added some commentary on how to add a new async segment, because I really wish there were docs for that when I started.

@romkatv
Copy link
Owner

romkatv commented Mar 8, 2021

Thanks for the PR. I should have time to look into it tomorrow.

@romkatv
Copy link
Owner

romkatv commented Mar 10, 2021

I took a look at the code and I think it would require a different design to make it more flexible. It wouldn't be easy for you to implement (powerlevel10k is optimized for my own maintenance costs with no regard for long it would take anyone else to do the job), so I'll do it myself when I get the time.

@git-rz
Copy link
Author

git-rz commented Mar 10, 2021

Indeed, there does seem to be some magic related to _CONTENT_EXPANSION that has totally eluded me. I also see that the icon customization should fully use the framework.

How different a design are you thinking? I see a pattern whereby many segments consist of subsegments, and the framework seems to have a developer-unfriendly approach to handling them (unless the dev is you :), as you just said.. ). If you're envisioning a sweeping update to improve that, then I'll gladly stay out of the way. Otherwise, I'm eager to learn and help finish this segment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants