-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for poetry virtualenv #1994
base: master
Are you sure you want to change the base?
Conversation
Hello, I tried to use you branch, but it didn't work |
Hello, @romkatv |
It's a valid feature request. Unfortunately, I cannot merge the PR as is. At this point I would need to go read about poetry and implement the thing. Unfortunately, I'm unlikely to ever find time for that. |
What could/should I do to improve this MR? @AleksandrLiadov the way I implemented support for poetry is to extend the current support for python venv. This means that if you want to mix both poetry and pyenv or any other venv technology then p10k only pick one. Another problem you may be facing is p10k already has something in its cache regarding this location. |
+1 Poetry is fast becoming the way to do projects in Python. |
I'll give a +1! Would be nice, and agreed that Poetry is certainly becoming more popular |
Heavily based on romkatv#1994. Integrate Poetry virtualenv detection into the existing virtualenv segment. For poetry virtualenvs, use the package name as reported by `poetry version`.
Hello everyone! I commented on #2450 that there is an alternative to have Poetry support: I hope that helps. Cheers! |
Never mind. We may be moving on to https://github.com/astral-sh/rye lol. The Python ecosystem is becoming as nutty as JavaScript's… |
Hi,
Here is a little patch in order to support poetry when looking for a project virtualenv.
This change adds two configuration variables: