Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set P9K_SSH correctly when running in WSL #2710

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JosefUtbult
Copy link

Solve #2709 by checking if system is running in WSL and in that case if it is running under an SSH session

@z0rc
Copy link

z0rc commented Jul 11, 2024

Powerlevel10k must be fast in all cases, in order to archive usage of external binaries is heavily constrained.

This means there should be no calls to grep, sed, no forks and subshells $() in general. Check surrounding code how parsing is implemented using Zsh parameter expansion.

@flash-me
Copy link

$(grep -i Microsoft /proc/version) && \ $(cmd.exe /c 'echo %SSH_CLIENT%'

1716066289000-1716192686485

@JosefUtbult
Copy link
Author

Powerlevel10k must be fast in all cases, in order to archive usage of external binaries is heavily constrained.

This means there should be no calls to grep, sed, no forks and subshells $() in general. Check surrounding code how parsing is implemented using Zsh parameter expansion.

Sure. I'll look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants