-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styling and appearance improvements #45
Conversation
…m class. Added disappearing scrollbar toggle.
Hi @orangecoloured , |
dist/customScroll.css
Outdated
position: absolute; | ||
height: 100%; | ||
width: 6px; | ||
width: 6x; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are missing 'p', should be 6px
@rommguy |
any progress with this PR? something i can help with? |
I think we could (or should) go with css modules for this use case. And in javascript use it as follows:
This will render to the DOM:
Of course for every change we made we need to update the docs, as this is a breaking change. I do think this change is a must. as mentioned by @orangecoloured, the CSS classes that are used in this library are very common and may conflict with other global CSS classes. |
I think we can close this as #51 solved it |
Added customisable css class prefix.
Removed inner thumb.
Added scrollbar track custom class.
Added disappearing scrollbar toggle.
Now if a user uses a custom prefix everything's going to break, because the prefix in the css is hardcoded. It can be fixed by introducing inline styling for everything with ability to add user style objects. But at least now styles have their own namespace.
Also, heavily edited formatting, because eslinter wouldn't allow me to build.