Current Serializer is hard to maintain
#175
Labels
Comments
This was referenced Jun 6, 2019
bors bot
added a commit
that referenced
this issue
Apr 27, 2020
206: feat: port `ser::Serializer` to `io::Write` r=kvark a=Plecra Makes the `Serializer` struct generic over `io::Write`, allowing it to be used with more types (and less allocation). As a side-effect, the trailing commas are also removed from the output. This was a quick implementation, written in response to compiler messages, so it could probably do with some cleaning up. It might be a good time to approach #175 Closes #202 ## TODO - [ ] Update docs Co-authored-by: Marli Frost <marli@frost.red>
Closed
bors bot
added a commit
that referenced
this issue
May 4, 2020
206: Port `ser::Serializer` to `io::Write` r=kvark a=Plecra Makes the `Serializer` struct generic over `io::Write`, allowing it to be used with more types (and less allocation). As a side-effect, the trailing commas are also removed from the output. This was a quick implementation, written in response to compiler messages, so it could probably do with some cleaning up. It might be a good time to approach #175 Closes #202 ## TODO - [ ] Update docs Co-authored-by: Marli Frost <marli@frost.red>
|
Issue has had no activity in the last 180 days and is going to be closed in 7 days if no further activity occurs |
|
This is still a problem, although we have more tests now thanks to @MomoLangenstein which should make refactoring easier. |
|
weird that GH actions bot closes this, even thought there is a comment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The problem
The current serializer provides all kind of config parameters, but as it is now, it became hard to maintain.
Many things are special cased, and code is duplicated across tuples / enums / sequences / maps.
Additionally, we're lacking tests for pretty serialization.
How to fix this
We need to build an abstraction for comma separated values, which removes the duplication we have now.
Once that's done, special cases should be easier to identify.
The text was updated successfully, but these errors were encountered: