Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy + rustfmt project #211

Closed
elrnv opened this issue Apr 18, 2020 · 3 comments
Closed

Clippy + rustfmt project #211

elrnv opened this issue Apr 18, 2020 · 3 comments

Comments

@elrnv
Copy link
Contributor

elrnv commented Apr 18, 2020

Should this project run through clippy and rustfmt checks in CI.

Given that there is an explicit rustfmt.toml it is surprising that the diff is currently so large when running rustfmt on the project.
@elrnv
Copy link
Contributor Author

elrnv commented Apr 18, 2020

To add, I would be happy to submit a PR for this.

@kvark
Copy link
Collaborator

kvark commented Apr 20, 2020

I think we should take this opportunity and switch to rustfmt stable, removing all the options that are nightly-only.
Clippy would be great! but perhaps not if it's going to block the PRs because of warnings.

This was referenced Apr 21, 2020
Merged
Merged
bors bot added a commit that referenced this issue Apr 21, 2020
@bors @elrnv
Merge #215
a92d5d9 
215: Add clippy to CI + address clippy problems r=kvark a=elrnv

This commit
1. Adds `cargo clippy` to .travis.yml that is allowed to fail to reduce friction for incoming PRs.
2. Addresses clippy concerns and clarifies places where they should be ignored.

Addresses half of #211

Co-authored-by: Egor Larionov <egor.larionov@gmail.com>
@elrnv
Copy link
Contributor Author

elrnv commented Apr 21, 2020

This is resolved by #215 and #214.

@elrnv elrnv closed this as completed Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @elrnv