Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check heterogeneous sequence doesn't become a list #127

Closed
wants to merge 1 commit into from

Conversation

torkleyy
Copy link
Contributor

@torkleyy torkleyy commented Aug 7, 2018

No description provided.

@torkleyy
Copy link
Contributor Author

torkleyy commented Aug 7, 2018

[Spoiler alert]
It doesn't. I meant it doesn't work, it does become a list :(

@torkleyy
Copy link
Contributor Author

torkleyy commented Aug 7, 2018

I don't know how to solve this. Currently tuples and lists share one Value variant, because JSON and other formats don't have the distinction either. I could theoretically make it two, but there's no way of telling what it is when I'm deserializing - there's only visit_seq, which is for tuples and lists.

@torkleyy
Copy link
Contributor Author

torkleyy commented Aug 7, 2018

I can't pass that information from the deserializer to the Value visitor..

@torkleyy
Copy link
Contributor Author

We need to consider making some contributions to serde and / or providing features that are not using serde. The current architecture design causes a couple of issues:

@torkleyy
Copy link
Contributor Author

Closing due to inactivity.

@torkleyy torkleyy closed this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant