Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clippy to CI + address clippy problems #215

Merged
merged 4 commits into from
Apr 21, 2020
Merged

Commits on Apr 21, 2020

  1. Add clippy to CI + address clippy problems

    This commit
    1. adds `cargo clippy` to .travis.yml
    2. addresses clippy concerns and clarifies places where they should be ignored.
    elrnv committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    f240858 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4ea661f View commit details
    Browse the repository at this point in the history
  3. Fix from_str errors caused by a clippy fix

    The issue was that the from_str implementation on Value was moved to the
    FromStr trait as recommended by Clippy. This caused many of the tests to
    fail since now the FromStr trait must be in scope. Instead of bringing
    FromStr into scope everywhere, however, the `Value::from_str(_)` calls
    were replaced with `_.parse()` calls as recommended by the std lib
    documentation.
    elrnv committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    0d2e1a8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0c7cf52 View commit details
    Browse the repository at this point in the history