Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v0.8.0 release #398

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Prepare v0.8.0 release #398

merged 1 commit into from
Aug 16, 2022

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Aug 15, 2022

Update CHANGELOG, README, Cargo.toml, and src/lib.rs for the v0.8.0 release.

  • I've included my change in CHANGELOG.md

@juntyr juntyr marked this pull request as draft August 15, 2022 16:12
@juntyr
Copy link
Member Author

juntyr commented Aug 15, 2022

@torkleyy @kvark I've created this draft PR to update ron to v0.8.0 - since this would be my first release PR I have no idea if I've done this correctly. Essentially I've just created a new v0.8 branch from main and written a PR for it which bumps every mention of 0.7 to 0.8. Does that look correct? I've given the release the tentative date of this Wednesday, August 17th.

@codecov-commenter
Copy link

Codecov Report

Merging #398 (3722636) into v0.8 (172bdd6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v0.8     #398   +/-   ##
=======================================
  Coverage   86.55%   86.55%           
=======================================
  Files          49       49           
  Lines        5803     5803           
=======================================
  Hits         5023     5023           
  Misses        780      780           
Impacted Files Coverage Δ
src/lib.rs 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we just need to make sure to merge these changes into master as well. In this case I wouldn't even create a branch and target master directly since we release from master. (the branch can be created afterwards if needed, from the tag)

@juntyr juntyr changed the base branch from v0.8 to master August 15, 2022 17:29
@juntyr juntyr marked this pull request as ready for review August 15, 2022 17:29
@juntyr
Copy link
Member Author

juntyr commented Aug 15, 2022

@torkleyy Ok, it's now targeting the main branch. Since you have the permissions to create the GitHub release and release to crates.io, you can merge the PR anytime you want (and if you'd like me to update the release date beforehand, I should be able to do that within a few minutes).

@torkleyy torkleyy merged commit 053bdf8 into ron-rs:master Aug 16, 2022
@juntyr juntyr deleted the v0.8 branch August 20, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants