-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lossless Value::Number
and allow +unsigned
#479
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #479 +/- ##
==========================================
- Coverage 85.28% 82.93% -2.36%
==========================================
Files 72 74 +2
Lines 8850 9257 +407
==========================================
+ Hits 7548 7677 +129
- Misses 1302 1580 +278
☔ View full report in Codecov by Sentry. |
Value::Number
Value::Number
and allow +unsigned
cdfe39a
to
c3af695
Compare
This PR
value
module a bitvalue::Number
enum to cover all possible number types losslesslyparser::AnyNum
type withvalue::Number
+unsigned
to parse as an unsigned integerI see this as a small improvement towards a better
Value
. While it does touch a lot of tests, sinceNumber
is more explicit now and always chooses the smallest variant that fits (andserde
'sDeserialize
impls do the rest by upcasting again if necessary), more control could be given to the user with #241, if someone wants to implement that.CHANGELOG.md