Sync Local #2
Merged
Sync Local #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Part of: #21342 This PR removes the prop types for the components `SwipeableFlatList` and `SwipeableQuickActions`. The props for `SwipeableFlatList` have been left as not $ReadOnly, because it needs the types in `Libraries/Lists/*` to also be cleaned up. A todo notice has been added. Pull Request resolved: #21384 Differential Revision: D10099694 Pulled By: TheSavior fbshipit-source-id: 424b900942c9a7889b664f351f79abee55923430
Summary: Replaces `ImageResizeMode` with a Flow type. JavaScript enums provide little value when you have a type system. Reviewed By: bvaughn, TheSavior Differential Revision: D10057237 fbshipit-source-id: f108b60795a6d82a6786421e4ac72aeedc53bee8
Summary: Removes the prop types from `LayoutAnimation` and refines the Flow types. This also disables `LayoutAnimation.checkConfig` with a `console.error`. Reviewed By: bvaughn Differential Revision: D10057234 fbshipit-source-id: a386f3d7dd5deafa1d4681d1f49821821fda9a6a
Summary: Fixes the runtime value of `ReactNativeStyleAttributes` to correctly map to `true` instead of strings (as returned by `keyMirror`). Reviewed By: TheSavior Differential Revision: D10057235 fbshipit-source-id: dc855cff3a114761098ed5176b2e6e25412481dc
Summary: UIAnimationDragCoefficient is 10.0 in tests for some reason, but we need it to be 1.0 for our tests. Reviewed By: PeteTheHeat Differential Revision: D10096375 fbshipit-source-id: 9acd042a3d87a9c6a253745fe48145f0442f6567
Summary: This change adds getter for overflow attribute in ReactViewGroup class. Overflow setting can affect how view children are drawn but also how hit testing behaves when receiving touch. Exposing this setting makes it possible for gesture-handler library to implement proper hit testing that takes into account overflow property of a view. Pull Request resolved: #21398 Differential Revision: D10105398 Pulled By: shergin fbshipit-source-id: 15ae2b31be3bf80e7e1d28b87ce4474af0f486f5
Summary: That should save us some app size kilobytes. Reviewed By: mdvacca Differential Revision: D10081499 fbshipit-source-id: 2b950768c609b412f9be332c22b6b1e96657e5ea
…convert to ES6 class Differential Revision: D10100555 Original commit changeset: ab350546f4fa fbshipit-source-id: 7afd51aacceac209564c06462ae60c4a12cf4815
Summary: update creation logic for text shadow: allow shadows with zero offset when the radius is nonzero (?should we also add a check to drop the node as a no-op when color.alpha == 0 ?) Reviewed By: yungsters Differential Revision: D10017778 fbshipit-source-id: 0168ac6db5ad22a5d7eb32dcd184aede361d6651
Summary: ... instead of using direction access to `ygNode.getLayout()` object. Suddenly, YGLayout object that YGNode exposes contains unresolved/directional-unaware styles. To get resolved directional-aware styles we have to use functions from Yoga.h. I am not happy with this solution, I will try to implement something like `ygNode.getResolvedLayout()` and use that instead. This change fixes strange missing horizontal padding around some views. Reviewed By: mdvacca Differential Revision: D10112049 fbshipit-source-id: 4b6ef39d8dd34e78a4592962e8af4eeaa5028768
Summary: Trivial. We missed `pointScaleFactor`. Reviewed By: mdvacca Differential Revision: D10112051 fbshipit-source-id: 980b8c310fbb3701008765509dce5b6e61852c0e
Differential Revision: D9930713 Original commit changeset: 4aa013f8398d fbshipit-source-id: 1fed02b41fa9d91f54d1a19f710bdb666701a4a0
Summary: This fixes cookie missing bug on Android 5.0 and above. On Android 5.0 and above, after the app successfully obtains the cookie, you kills the App within 30 seconds and restarts the App. It accesses the interface that needs to carry the cookie and finds that the cookie does not exist. Updated tests for the addCookies function to include test cases specifying Android version, and tested on the command line in my app to make sure it has the expected behavior. Updated tests for the addCookies function to include test cases specifying Android version, and tested on the command line in my app to make sure it has the expected behavior. [ANDROID] [BUGFIX] [Cookie] - Fix cookies lost on Android 5.0 and above Pull Request resolved: #19770 Differential Revision: D10114102 Pulled By: hramos fbshipit-source-id: 5b4766f02f70541fd46ac5db36f1179fe386ac7a
Summary: As recommended in https://circleci.com/docs/2.0/using-shell-scripts/#use-shellcheck It will only run on PRs for now. Pull Request resolved: #19681 Differential Revision: D10111711 Pulled By: hramos fbshipit-source-id: e980a526561dced79e5197a11cfb41a3eba9be8b
Reviewed By: yungsters Differential Revision: D10115867 fbshipit-source-id: be619b9d6fc30e318cbc0e0fc6e741d80dd94a4b
Summary: Update several files to use the proper copyright header: ``` // Copyright (c) Facebook, Inc. and its affiliates. // // This source code is licensed under the MIT license found in the // LICENSE file in the root directory of this source tree. ``` In the case of Xcode project files, I used the shortform version, `Copyright (c) Facebook, Inc. and its affiliates.` Reviewed By: axe-fb Differential Revision: D10114529 fbshipit-source-id: a1f2d5a46d04797c1cf281ea9ab80d3a2caa6fb4
…#21387) Summary: related #21342 TODO * move ImageSourcePropType.js, ImageStylePropTypes.js, TextPropTypes.js * fix flow error CheckList - [x] `yarn prettier` - [x] `yarn flow-check-android` - [x] `yarn flow-check-ios` All flow checks pass. [GENERAL] [ENHANCEMENT] [DeprecatedImageSourcePropType.js] - Created. [GENERAL] [ENHANCEMENT] [DeprecatedImageStylePropTypes.js] - Created. [GENERAL] [ENHANCEMENT] [DeprecatedTextPropTypes.js] - Created. Pull Request resolved: #21387 Reviewed By: TheSavior Differential Revision: D10099753 Pulled By: RSNara fbshipit-source-id: c907af6d1549ee42de1a2e17f278998e8422110f
Reviewed By: TheSavior Differential Revision: D10101195 fbshipit-source-id: 5c8cde81f92cac87b6cfe3fc1a36c78e4862c5ff
Summary: Upgrades all dependents of `fbjs` to the latest version. Reviewed By: mjesun Differential Revision: D10100661 fbshipit-source-id: 2e2af616cb2b5eab560872b6c6c60ed264e986b2
Summary: Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. _Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_ Pull Request resolved: #21396 Differential Revision: D10119630 Pulled By: RSNara fbshipit-source-id: d0fe193eee976b9b18a2eb467b5f3af48bd7d2de
… for now) Summary: This change implements `onLayoutOnly` for regular bare <View> component (*not* for its descendants!) After this view flattening is actually starting working for all platforms. Reviewed By: mdvacca Differential Revision: D9511001 fbshipit-source-id: 3562dd1b7570a064150f100cc2e1bc4220b81290
Summary: Related to #21342 * Renamed ViewStyleProps to DeprecatedViewStyleProps. * Moved propType declaration to `react-native/Libraries/DeprecatedPropTypes` * ImageProps.js: moved propType declarations to DeprecatedImageProps.js. Pull Request resolved: #21415 Reviewed By: TheSavior Differential Revision: D10119599 Pulled By: RSNara fbshipit-source-id: 67674039a88dcd570973c7062f86ebdbd6987d28
Summary: related #21342 TODO * move LayoutPropType.js * fix flow error CheckList - [x] `yarn prettier` - [x] `yarn flow-check-android` - [x] `yarn flow-check-ios` All flow checks pass. [GENERAL] [ENHANCEMENT] [DeprecatedLayoutPropTypes.js] - Created. [GENERAL] [ENHANCEMENT] [StyleSheetTypes.js] - add comments. Pull Request resolved: #21370 Differential Revision: D10099715 Pulled By: RSNara fbshipit-source-id: d0515fe0d56d9ed2fde50cc0bfb75b63aded1f5d
Summary: This PR fixes an obscure rendering bug on iOS for borders with asymmetric radii. It appears to be a problem with the custom drawing that React Native performs when it cannot use native UIKit/CoreAnimation border drawing. Pull Request resolved: #21208 Differential Revision: D10130120 Pulled By: hramos fbshipit-source-id: d9fbc5c622c060db15658d038a068216b47bb26d
Summary: Currently, loading SO libraries is pretty expensive. While they are triggered due to accessing `ReadableNativeArray`. However, with preloader experiments, this block seems to move around and is loaded when the first dependent class loads it. Also, as a part of D10108380, this will be moved again. Adding a trace to keep track of where it moves. Reviewed By: achen1 Differential Revision: D9890280 fbshipit-source-id: 4b331ef1d7e824935bf3708442537349d2d631d0
Summary: Many of the optional types from the PR could have been made non-optional. I just made the change because it was simple enough to make and verify. Reviewed By: TheSavior Differential Revision: D10131969 fbshipit-source-id: b84693b5549708d7948fe3fd54295bc80be93790
Summary: Migrate ReactContentSizeUpdateTest off of SubscribableMixin Reviewed By: RSNara Differential Revision: D10244324 fbshipit-source-id: 97cf392cf1bd2522dfbfb1968d08b3737b0a7f15
Summary:
With the new xcode command line tools (10.1 beta2), running `xcrun simctl list --json devices` seems to gives us a slightly different format than what we were expecting. More specifically, the `availability` key is changed to `isAvailable` and returns `'YES'` if the simulator is available:
Before:
```js
devices: {
'iOS 9.2': [
{
state: 'Shutdown',
availability: '(unavailable, runtime profile not found)',
name: 'iPhone 4s',
udid: 'B9B5E161-416B-43C4-A78F-729CB96CC8C6',
},
{
state: 'Shutdown',
availability: '(unavailable, runtime profile not found)',
name: 'iPhone 5',
udid: '1CCBBF8B-5773-4EA6-BD6F-C308C87A1ADB',
},
...
]
}
```
After:
```js
devices: {
'iOS 12.1': [
{
state: 'Shutdown',
isAvailable: 'YES',
name: 'iPhone 6s',
udid: 'D0F29BE7-CC3C-4976-888D-C739B4F50508',
},
{
state: 'Shutdown',
isAvailable: 'YES',
name: 'iPhone 6',
udid: 'BA0D93BD-07E6-4182-9B0A-F60A2474139C',
},
...
]
}
```
Without this fix, `npm run ios` is not able to launch the simulator correctly and returns the following error:
```
Could not find iPhone 6 simulator
Error: Could not find iPhone 6 simulator
at resolve (/Users/antonyc/Projects/AwesomeProject/node_modules/react-native/local-cli/runIOS/runIOS.js:148:13)
at new Promise (<anonymous>)
at runOnSimulator (/Users/antonyc/Projects/AwesomeProject/node_modules/react-native/local-cli/runIOS/runIOS.js:134:10)
at Object.runIOS [as func] (/Users/antonyc/Projects/AwesomeProject/node_modules/react-native/local-cli/runIOS/runIOS.js:106:12)
at Promise.resolve.then (/Users/antonyc/Projects/AwesomeProject/node_modules/react-native/local-cli/cliEntry.js:117:22)
```
Pull Request resolved: #21557
Differential Revision: D10248115
Pulled By: TheSavior
fbshipit-source-id: 37197bbf828e4a6e254270d46411a6716a91afe3
Summary: The `BUCK` build files' indentation are 4 spaces large. This PR adds a small modification to `.editorconfig` to reflect that. Especially important for them, because an improperly indented line would be a syntax error. Pull Request resolved: #21554 Differential Revision: D10247954 Pulled By: TheSavior fbshipit-source-id: 98596a563e9f8c36060cd8aa702757eff230c4c3
Summary: Updated Button component inspiration. Refactored code takes advantage of Platform Specific Code, as we want to re-use as much code as possible. 1. Import Button component 2. Button should work the same #19752 [GENERAL] [ENHANCEMENT] [Button] - Uses spread operator for platform specific code in creating styles Pull Request resolved: #21535 Differential Revision: D10248048 Pulled By: TheSavior fbshipit-source-id: 7260fa56f15b70b7c9499c8da418db7b2214b0dd
Summary: This adds a synchronous method that JS can call to load view managers. Notably, we don't have an exact way to go from a JS name to the native view manager, so this naively adds 'Manager' to the end. After lazily loading the view, it makes sure to cache all its values in native and JS, as further calls from JS will fail. Reviewed By: PeteTheHeat Differential Revision: D10204314 fbshipit-source-id: ebf42a85dcc467f3b4c5d6e18e49e04f9e8aa4f9
Summary: Related to #21581 . Removed createReactClass from the RNTester/js/TextExample.ios.js - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android [GENERAL] [ENHANCEMENT] [RNTester/js/TextExample.ios.js] - remove createReactClass dependency Pull Request resolved: #21603 Differential Revision: D10260872 Pulled By: RSNara fbshipit-source-id: f63476756a10ddbce04da901012247d028579d53
Summary: This component has long been deprecated in the docs. Adding a warning to the code. Reviewed By: sahrens Differential Revision: D10261155 fbshipit-source-id: 462ce30a97f35e52477cfc135fb50c976b56e9cb
Summary: With new `ShadowTree::getRootShadowNode()` method all access to rootShadowNode_ is protected by commit mutex. Reviewed By: mdvacca Differential Revision: D10159456 fbshipit-source-id: 0bc8676ca2564a8ef95d60e912356e99d9f172c1
Summary: That's actually proper defaults. That fixes problems with horizontally bouncing ScrollView. Reviewed By: mdvacca Differential Revision: D10159458 fbshipit-source-id: b2b6df911b0a23f5e13539caeb48e51cdbc56528
Summary: Setting the right expectations: setting layout constraints might fail. Nothing really changed. Implementing a reliable `constraintLayout` which locks instead of returning immediately requires some additional work and new/additional API. Reviewed By: mdvacca Differential Revision: D10159457 fbshipit-source-id: bb23c7de105629ef086ae0b04667ff32c6ffb81d
Summary: New `ShadowTree::synchronize` method allows to perform operations on ShadowTree without a risk of an unsuccessful commit. To make it happen, the `commitMutex_` is now recursive and `synchronize` acquires it before calling the callback. Using that we finally can implement reliable `constraintLayout`. Reviewed By: mdvacca Differential Revision: D10174281 fbshipit-source-id: 9864ebb5343d40e2da205272a834710f0ab730db
Summary: Size constraints are essential part of the running Surface, decoupling them from starting process means that we will have to perform additional commit later. This and previous couple diffs fix a problem with initial zero size of the surface and following visible "jumpy" relayout. Reviewed By: sahrens Differential Revision: D10174280 fbshipit-source-id: 0ec48692cb814fd46cc3a1d044c5eb8ab9ecb031
Summary: Quite obviously, having a `complete` method which accepts only `newRootShadowNode` was a baaad idea. When we `complete` or `commit` we always have to have two nodes (before and after). And only after layout and right before swapping (and acquiring the mutex) we have to verify that *current* root node is still the same as it was when we initialized the transaction (if not, we have to abort). Reviewed By: mdvacca Differential Revision: D10201902 fbshipit-source-id: 15adc78c5d31d6fd39fd7fc6e53203a5539717a8
Summary: This is the second and the final part of adopting clang-format. Reviewed By: mdvacca Differential Revision: D10229624 fbshipit-source-id: d97670b716800ea2488b84bd0aacaf54d8bd2e31
Summary: Previsouly, we basically didn't support Accessibility at all. Reviewed By: mdvacca Differential Revision: D10250635 fbshipit-source-id: d33eed8f56374f57310654653f41c312cb5942e6
Summary: This diff introduces the collapsable props in the viewProps. This prop is used in product code to prevent specific Views to be removed from the view hierarchy Reviewed By: shergin Differential Revision: D10254679 fbshipit-source-id: 637665b8998a86e29e839eb6d405a0fac354c8d3
Summary: This diff enables view flattening for Android when using Fabric. Reviewed By: shergin Differential Revision: D10254678 fbshipit-source-id: cc7acaa38a6d01e112ba0e8a92db61cdeefbffee
Summary: This diff enables the onPress event for TextViews that render RawText Reviewed By: shergin Differential Revision: D10222183 fbshipit-source-id: 4b6a6ad548286453f7dd3a14a5e4ee453a55b923
Summary: This diff avoids the serialization of color that are set as: "UndefinedColor". This allows the text rendering system to set the default color in the native side Reviewed By: shergin Differential Revision: D10275834 fbshipit-source-id: b81c7a5995bef65e04a246d99f44ff10cb20f548
Summary: Related to #21581 Remove createReactClass from ListViewExample and ListViewGridLayoutExample - All flow tests succeed. - Run RNTester app, go to ListView component, scroll, expand rows, everything works. - Run RNTester app, go to ListViewGridLayout component, scroll, click on icons, everything works. [GENERAL] [ENHANCEMENT] [ListViewExample.js] - rm createReactClass [GENERAL] [ENHANCEMENT] [ListViewGridLayoutExample.js] - rm createReactClass Pull Request resolved: #21582 Differential Revision: D10274350 Pulled By: RSNara fbshipit-source-id: 4ea505a0f9661300309d6b9457202085293333b5
…21613) Summary: Related to #21581 . Removed createReactClass from the RNTester/js/SwipeableFlatListExample.js Test Plan ----- - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android - [x] Run RNTester app, go to SwipeableFlatList component, everything works. Release Notes -------- [GENERAL] [ENHANCEMENT] [RNTester/js/SwipeableFlatListExample.js] - remove createReactClass dependency Pull Request resolved: #21613 Differential Revision: D10275399 Pulled By: RSNara fbshipit-source-id: 63030ca7da979a3d25bb94d52d4fd59994504aa3
Summary: `legacyImplementation` has caused a warning in FlatList for a long time. FlatList supports the use cases of the legacy implementation and should be adopted. We will be removing the deprecated MetroListView and ListView components to reduce bundle sizes and the complexity of the codebase. Reviewed By: yungsters Differential Revision: D10245824 fbshipit-source-id: 60ff0d54974649b57bac9f9f29b769f34ca2701c
Reviewed By: yungsters Differential Revision: D10251054 fbshipit-source-id: dc801817dfcf2722e4625178117006ab51e57255
Summary: This consists of several fixes: - Some of the C++ functions called by the tests were missing `WIN_EXPORT` - It looks like Yoga was changed to round up after `TestMeasureFuncWithFloat` was written. Here's the function call that results in the rounding: https://github.com/facebook/yoga/blob/357ca78f9f7bd86298ef00a1426cac5ca2041d3b/yoga/Yoga.cpp#L4019-L4026 - The format of the result of the `Print` method was changed after `TestPrint` was written. Pull Request resolved: facebook/yoga#818 Differential Revision: D10282902 Pulled By: shergin fbshipit-source-id: a5fd732a7dbff1a704cbafbfc95ae3e0c0a0cdd8
Summary: Related to #21485. Removed Subscribable.Mixin from the Libraries/Components/ScrollResponder.js - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android [GENERAL] [ENHANCEMENT] [Libraries/Components/ScrollResponder.js] - remove Subscribable.Mixin dependency Pull Request resolved: #21589 Differential Revision: D10275517 Pulled By: RSNara fbshipit-source-id: 28af7f0944e978609a1b3be05b8a51557e67bc1b
Summary: Android requires lowercase for URL scheme. This commit d00bdb9 fixed it but on React Native side. Because it is Android specific, it should be fixed on Android side. Android has method to normalize url scheme: https://developer.android.com/reference/android/net/Uri.html#normalizeScheme() Pull Request resolved: #21561 Differential Revision: D10287868 Pulled By: hramos fbshipit-source-id: f5e474164fdb2cfd49bd8ee51da17de3f1341a9c
Summary: Related to #21485 Remove SubscribableMixin from SizeFlexibilityUpdateTest - All flow tests succeed. - yarn run test-android-instrumentation && CI integration tests [GENERAL] [ENHANCEMENT] [SizeFlexibilityUpdateTest.js] - rm SubscribableMixin Pull Request resolved: #21580 Reviewed By: TheSavior Differential Revision: D10276267 Pulled By: RSNara fbshipit-source-id: fc89b43099c788cba560c9aaf0819cd5cfab38c3
Summary: Updating to Detox 9 - this should help with better Xcode 10 support, and should fix #21539. I've updated to fixed `9.0.4` since it seems that each version is fairly different from the next, and I've followed the [migration guide](https://github.com/wix/detox/blob/master/docs/Guide.Migration.md#migrating-from-detox-8xx-to-9xx) for the android native dependencies. Release Notes: [INTERNAL] [ENHANCEMENT] [DETOX] - Update to version 9.0.4 Pull Request resolved: #21570 Reviewed By: TheSavior Differential Revision: D10242373 Pulled By: RSNara fbshipit-source-id: bd29d554e0972f16d96b9b39b86c7143941d5b7c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.
If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!
Test Plan:
Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[CATEGORY] [TYPE] [LOCATION] - Message