Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: store audits on mongodb #427

Merged
merged 27 commits into from
Jan 20, 2025
Merged

feat: store audits on mongodb #427

merged 27 commits into from
Jan 20, 2025

Conversation

fredmaggiowski
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jan 15, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12872340655

Details

  • 239 of 295 (81.02%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 85.644%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/config/env.go 11 12 91.67%
internal/testutils/mongodb.go 44 45 97.78%
internal/audit/agent_mongodb.go 19 24 79.17%
internal/testutils/mongoclient.go 3 10 30.0%
sdk/evaluator.go 8 28 28.57%
main.go 18 40 45.0%
Totals Coverage Status
Change from base Build 12864432906: -0.5%
Covered Lines: 2804
Relevant Lines: 3274
💛 - Coveralls

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 17, 2025
View reviewed changes
davidebianchi
davidebianchi reviewed Jan 20, 2025
View reviewed changes
@fredmaggiowski fredmaggiowski marked this pull request as ready for review January 20, 2025 10:48
fredmaggiowski
fredmaggiowski commented Jan 20, 2025
View reviewed changes
davidebianchi
davidebianchi approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@davidebianchi davidebianchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danielemarostica
danielemarostica approved these changes Jan 20, 2025
View reviewed changes
Copy link

@danielemarostica danielemarostica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredmaggiowski fredmaggiowski merged commit 2677714 into main Jan 20, 2025
10 checks passed
@fredmaggiowski fredmaggiowski deleted the feat/store-audits-on-mongodb branch January 20, 2025 16:55
@fredmaggiowski fredmaggiowski added the enhancement New feature or request label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidebianchi davidebianchi davidebianchi approved these changes

@danielemarostica danielemarostica danielemarostica approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fredmaggiowski @coveralls @davidebianchi @danielemarostica