Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Self TypeVar for SSHConnection __aenter__ #600

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Use Self TypeVar for SSHConnection __aenter__ #600

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea46520
Use Self TypeVar for SSHConnection __aenter__
PJB3005 Oct 17, 2023
cad4aa8
Use single quotes
PJB3005 Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion asyncssh/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@
_ProtocolFactory = Union[_ClientFactory, _ServerFactory]

_Conn = TypeVar('_Conn', 'SSHClientConnection', 'SSHServerConnection')
_ConnSelf = TypeVar('_ConnSelf', bound='SSHConnection')

class _TunnelProtocol(Protocol):
"""Base protocol for connections to tunnel SSH over"""
Expand Down Expand Up @@ -893,7 +894,7 @@ def __init__(self, loop: asyncio.AbstractEventLoop,

self._disable_trivial_auth = False

async def __aenter__(self) -> 'SSHConnection':
async def __aenter__(self: _ConnSelf) -> _ConnSelf:
"""Allow SSHConnection to be used as an async context manager"""

return self
Expand Down