fix read_batch behavior for visgeno testing #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing scripts in exp-visgeno-rel
The
DataReader
allows to read the same batch several times even at testing time, if a batch raises an IOError inrun_prefetch
fromutil/visgeno_rel_train/rel_data_reader.py
, it does not incrementself.n_batch
causing the reader to eventually read the first batch once again without incrementingself.n_epoch
.For example in
exp-visgeno-rel/exp_test_visgeno_attbilstm.py
, the test runs overreader.num_batch
(equals 5000 in case of imdb_tst) but 127 batches of imdb_tst does not contain any relationship causingprepare_batch
to raise an IOError, caught byrun_prefetch
and it does not do anything in that case. Eventually the first 127 batches of imdb_tst are read and been computed scores once again. I think this is not an intended behavior, ratherexp_test_visgeno_attbilstm.py
(and other testing scripts) should compute scores against batches containing relationships only once.To solve the problem, I suggest that
run_prefetch
adds None to the prefetch_queue in case of an "empty" batch.In testing scripts such as
exp_test_visgeno_attbilstm.py
if read_batch is Nonen_iter
is incremented and we move to the next batch.