Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print version of ronin package #40

Merged
merged 7 commits into from
Jan 27, 2025
Merged

Print version of ronin package #40

merged 7 commits into from
Jan 27, 2025

Conversation

leo
Copy link
Member

@leo leo commented Jan 27, 2025

This change ensures that the CLI always prints the version of the ronin package when --version is passed.

So far, it was printing the version of @ronin/cli, which is misleading.

In the future, we might choose to create a @ronin/client package, in which case @ronin/cli will be usable standalone. But for the time being, the shorter ronin package name makes more sense.

@leo leo added the enhancement New feature or request label Jan 27, 2025
@leo leo requested review from NuroDev, juriadams and colodenn January 27, 2025 11:14
Copy link

github-actions bot commented Jan 27, 2025

Released an experimental package:

bun add @ronin/cli@leo-ron-1099-experimental-97

This package will be removed after the pull request has been merged.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

@leo leo marked this pull request as ready for review January 27, 2025 11:34
@leo leo enabled auto-merge (squash) January 27, 2025 11:34
@leo leo merged commit 80b29ac into main Jan 27, 2025
3 checks passed
@leo leo deleted the leo/ron-1099 branch January 27, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants