Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow migration of adding or dropping unique columns #44

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Conversation

colodenn
Copy link
Member

@colodenn colodenn commented Jan 29, 2025

A customer reported an issue where migrations involving adding or dropping a unique column were failing. This happens because SQLite's ALTER TABLE does not support adding or dropping unique columns directly. To address this, we now detect when a unique column is added or removed and create a temporary table to handle the migration properly.

@colodenn colodenn requested a review from leo January 29, 2025 11:57
@colodenn colodenn self-assigned this Jan 29, 2025
Copy link

Released an experimental package:

bun add @ronin/cli@corny-ron-1099-experimental-106

This package will be removed after the pull request has been merged.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/utils/field.ts 100.00% <100.00%> (ø)
src/utils/queries.ts 100.00% <100.00%> (ø)
tests/fixtures/index.ts 100.00% <100.00%> (ø)

@colodenn colodenn marked this pull request as ready for review January 29, 2025 12:28
@colodenn colodenn merged commit 91edf0f into main Jan 29, 2025
3 checks passed
@colodenn colodenn deleted the corny/ron-1099 branch January 29, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants