Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration now allows to add required fields #54

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Conversation

colodenn
Copy link
Member

Previously, developers couldn't add required fields without default values in SQLite because adding a column to a table with existing rows would result in empty values, conflicting with the required property. Now, developers are prompted to set a temporary default value.

@colodenn colodenn requested a review from leo February 13, 2025 12:27
@colodenn colodenn self-assigned this Feb 13, 2025
Copy link

github-actions bot commented Feb 13, 2025

Released an experimental package:

bun add @ronin/cli@corny-ron-1099-1-experimental-131

This package will be removed after the pull request has been merged.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/utils/field.ts 100.00% <100.00%> (ø)
src/utils/migration.ts 100.00% <100.00%> (ø)
tests/fixtures/index.ts 100.00% <100.00%> (ø)
tests/fixtures/utils.ts 100.00% <100.00%> (ø)

@colodenn colodenn marked this pull request as ready for review February 13, 2025 13:06
Copy link
Member

@leo leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@colodenn colodenn merged commit 4911f9d into main Feb 13, 2025
3 checks passed
@colodenn colodenn deleted the corny/ron-1099-1 branch February 13, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants