Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Upgrade launchModeExperimental to use estable launchMode #353

Merged

Conversation

AlejandroGutierrezB
Copy link
Contributor

Description

Upgrade launchModeExperimental to use stable launchMode property in app.json.ejs

Motivation and Context

Just house keeping to ensure repo is up to date

How Has This Been Tested?

It's a non breaking change

@danstepanov danstepanov requested a review from dannyhw July 10, 2024 23:42
@danstepanov
Copy link
Collaborator

@AlejandroGutierrezB You're missing a changeset https://github.com/roninoss/create-expo-stack/blob/main/contributing.md#make-your-changes

@AlejandroGutierrezB
Copy link
Contributor Author

@danstepanov ups! fixed

@danstepanov
Copy link
Collaborator

@dannyhw lmk once you've reviewed

Copy link
Collaborator

@dannyhw dannyhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks to be working. Thanks

@danstepanov danstepanov merged commit 8ccbe1d into roninoss:main Jul 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants