Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for non interactive nwui setup #390

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Allow for non interactive nwui setup #390

merged 3 commits into from
Aug 20, 2024

Conversation

dannyhw
Copy link
Collaborator

@dannyhw dannyhw commented Aug 9, 2024 •
edited
Loading

Description

  1. I updated the nwui call to use the --yes flag that makes it work with --no-install and makes it non interactive
  2. I moved it before the formatting step to make sure prettier runs after all code generation.

NOTE: we need nwui stable release to go out so that the --yes flag will exist

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

@dannyhw dannyhw marked this pull request as draft August 9, 2024 22:10
@danstepanov
Copy link
Collaborator

FYI @dannyhw this is in staging for NWUI

@dannyhw dannyhw marked this pull request as ready for review August 20, 2024 06:53
@danstepanov danstepanov merged commit ac31270 into main Aug 20, 2024
1 check passed
@danstepanov danstepanov mentioned this pull request Aug 20, 2024
Merged
@sammoore sammoore mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannyhw @danstepanov