Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure npmrc gets added for pnpm #406

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

dannyhw
Copy link
Collaborator

@dannyhw dannyhw commented Aug 27, 2024

Description

Nativewindui creates its own list of files separate from the base so npmrc wasn't getting added

I just moved it to the end so that its always applied when pnpm is used

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Copy link
Collaborator

@danstepanov danstepanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danstepanov
Copy link
Collaborator

@dannyhw tests aren't passing

@danstepanov danstepanov merged commit c31dedb into main Aug 27, 2024
1 check passed
@danstepanov
Copy link
Collaborator

fixed

@danstepanov danstepanov deleted the fix/npmrc-not-added-pnpm branch August 27, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants