Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rule: implicit_case_default -- basic implementation #4

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

ronitnallagatla
Copy link
Owner

Implementation for implicit_case_default rule.

  • Create a list of all LHS variables when you enter an always block
  • Check whether case statement has an explicit default arm --> pass
  • Else, check if variable in case statement has been previously assigned to, by looking at LHS variable list

TODO

  • Need to test cases where multiple signals are driven in the case
  • Make sure that only the signals under the always block are added to LHS vars list

Relevant Issues

Copy link
Collaborator

@ShreChinno ShreChinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@5han7anu-S 5han7anu-S merged commit 1e9c772 into implicit_case_default Feb 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants