-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Rule: implicit case default -- updated implementation #5
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## implicit_case_default #5 +/- ##
=========================================================
- Coverage 86.68% 86.51% -0.18%
=========================================================
Files 156 156
Lines 8121 7965 -156
=========================================================
- Hits 7040 6891 -149
+ Misses 1081 1074 -7 ☔ View full report in Codecov by Sentry. |
} | ||
|
||
fn name(&self) -> String { | ||
String::from("implicit_case_default") | ||
} | ||
|
||
fn hint(&self, _option: &ConfigOption) -> String { | ||
String::from("Signal driven in `case` statement does not have a default value.") | ||
String::from("Signal driven in `case` statement does not have a default value. Define a default case or implicitly define before `case` statement.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hint is probably too long. Might need to wrap at 80 chars
Updated Implementation
always
construct blocktrue
fail
, but if default exists, returnpass
, otherwise, returnfail
Relevant Issues