controllers: use zoom helper, fix zoom ranges

ronso0 · Nov 29, 2023 · 0df920a · 0df920a
1 parent 23cd6fb
commit 0df920a
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 18 deletions.
diff --git a/res/controllers/KANE_QuNeo_scripts.js b/res/controllers/KANE_QuNeo_scripts.js
@@ -888,9 +888,8 @@ KANE_QuNeo.closeSliderMode = function () {
 KANE_QuNeo.deckZoom = function (deck, value) {
     var channel = deck - 1; // track channels start at 0 to properly reference arrays
     var channelName = KANE_QuNeo.getChannelName(deck)
-    var normalized = Math.ceil(6 * ((127 - value) / 127))
     // adjust zoom
-    engine.setValue(channelName, "waveform_zoom", normalized)
+    script.waveformZoom(group, value, true);
 }
 
 KANE_QuNeo.deckCursor = function (deck, value) {
@@ -2347,8 +2346,10 @@ KANE_QuNeo.masterVuMeter = function (value) {
 // Sliders
 KANE_QuNeo.deckZoomLEDs = function (deck, value) {
     var LEDGroup = KANE_QuNeo.getLEDGroup(deck);
+    // TODO Add script.zoomToMidiValue() ?
     // normalize zoom LED value to be 0-127
-    var zoom = ((value - 1) / 5) * 127
+    // get range from src/waveform/renderers/waveformwidgetrenderer.cpp
+    var zoom = ((value - 1) / 9) * 127
     // determine which control we are manipulating
     var control = KANE_QuNeo.getSliderControl(deck, 0)
     // emit message

diff --git a/res/controllers/Korg-nanoKONTROL-2-scripts.js b/res/controllers/Korg-nanoKONTROL-2-scripts.js
@@ -506,13 +506,9 @@ NK2.toggleBinaryControlAll = function toggleBinaryControlAll(control){
 NK2.wavezoomAll = function wavezoomAll(value){
     if (NK2.debug>2){print("##function: "+NK2.getFunctionName())};
 
-    var range=6-1;
-    var newValue=Math.round(1+((value/127)*range));
-    if (newValue>6)newValue=6;
-    if (newValue<1)newValue=1;
     if (NK2.lastwavevalue!=value){
-        for (var i=1; i<9; i++){
-            engine.setValue(NK2.Deck[i], "waveform_zoom", newValue);
+        for (var i=1; i<=NK2.numDecks; i++){
+            script.waveformZoom(NK2.Deck[i], value, true);
         };
     }
     NK2.lastwavevalue=value;
@@ -522,12 +518,8 @@ NK2.wavezoomDeck = function wavezoomDeck(value, group){
     if (NK2.debug>2){print("##function: "+NK2.getFunctionName())};
     if (group=="default"){group=NK2.Deck[NK2.curDeck];};
 
-    var range=6-1;
-    var newValue=Math.round(1+((value/127)*range));
-    if (newValue>6)newValue=6;
-    if (newValue<1)newValue=1;
     if (NK2.lastwavevalue!=value){
-        engine.setValue(group, "waveform_zoom", newValue);
+        script.waveformZoom(group, value, true);
     }
     NK2.lastwavevalue=value;
     }

diff --git a/res/controllers/Novation-Launchpad MK2-scripts.js b/res/controllers/Novation-Launchpad MK2-scripts.js
@@ -4410,7 +4410,8 @@ var NLMK2 = (function () {
 	    waveform_zoom: {
 	      group: `[${type}${i}]`,
 	      name: 'waveform_zoom',
-	      type: '1.0 - 6.0'
+             // get range from src/waveform/renderers/waveformwidgetrenderer.cpp
+	      type: '1.0 - 10.0'
 	    },
 	    waveform_zoom_up: {
 	      group: `[${type}${i}]`,

diff --git a/res/controllers/Novation-Launchpad Mini MK3-scripts.js b/res/controllers/Novation-Launchpad Mini MK3-scripts.js
@@ -4410,7 +4410,8 @@ var NLMMK3 = (function () {
 	    waveform_zoom: {
 	      group: `[${type}${i}]`,
 	      name: 'waveform_zoom',
-	      type: '1.0 - 6.0'
+             // get range from src/waveform/renderers/waveformwidgetrenderer.cpp
+	      type: '1.0 - 10.0'
 	    },
 	    waveform_zoom_up: {
 	      group: `[${type}${i}]`,

diff --git a/res/controllers/Novation-Launchpad-Mini-scripts.js b/res/controllers/Novation-Launchpad-Mini-scripts.js
@@ -337,7 +337,8 @@ function ZoomKey(dir) {
     that.onPushOrig = that.onPush;
     that.onPush = function()
     {
-        if ( ZoomKey.zoom < 6 && this.dir == "+" ) {
+        // get range from src/waveform/renderers/waveformwidgetrenderer.cpp
+        if ( ZoomKey.zoom < 10 && this.dir == "+" ) {
             ZoomKey.zoom++;
         }
         if ( ZoomKey.zoom > 1 && this.dir == "-") {

diff --git a/res/controllers/Novation-Launchpad-scripts.js b/res/controllers/Novation-Launchpad-scripts.js
@@ -4410,7 +4410,8 @@ var NLMK1 = (function () {
 	    waveform_zoom: {
 	      group: `[${type}${i}]`,
 	      name: 'waveform_zoom',
-	      type: '1.0 - 6.0'
+             // get range from src/waveform/renderers/waveformwidgetrenderer.cpp
+	      type: '1.0 - 10.0'
 	    },
 	    waveform_zoom_up: {
 	      group: `[${type}${i}]`,