Filter due notes when all are scheduled

Ignore notes due in the future. Fixes st3v3nmw#548
ronzulu · May 1, 2024 · 2254709 · 2254709
1 parent 46f2e82
commit 2254709
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
+[Unreleased]
+
+- Fixed notes selection when all notes are reviewed. [`#548`](https://github.com/st3v3nmw/obsidian-spaced-repetition/issues/548)
+
 #### [1.12.4](https://github.com/st3v3nmw/obsidian-spaced-repetition/compare/1.12.3...1.12.4)
 
 - chore: fix package manager issue in CI [`#939`](https://github.com/st3v3nmw/obsidian-spaced-repetition/pull/939)

diff --git a/src/main.ts b/src/main.ts
@@ -756,11 +756,13 @@ export default class SRPlugin extends Plugin {
  this.lastSelectedReviewDeck = deckKey;
  const deck = this.reviewDecks[deckKey];
 
- if (deck.dueNotesCount > 0) {
+ const nowUnix = Date.now();
+ const dueNotes = deck.scheduledNotes.filter((note) => note.dueUnix <= nowUnix);
+ if (dueNotes.length > 0) {
  const index = this.data.settings.openRandomNote
- ? Math.floor(Math.random() * deck.dueNotesCount)
+ ? Math.floor(Math.random() * dueNotes.length)
  : 0;
- await this.app.workspace.getLeaf().openFile(deck.scheduledNotes[index].note);
+ await this.app.workspace.getLeaf().openFile(dueNotes[index].note);
  return;
  }