Merge pull request #466 from will89/improve-utils-each_element

Reduce array allocations in Roo::Utils.each_element
roo-rb · Oct 14, 2018 · 01d1a1c · 01d1a1c
2 parents 5fc4378 + 467f163
commit 01d1a1c
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/roo/utils.rb b/lib/roo/utils.rb
@@ -81,8 +81,9 @@ def load_xml(path)
 
     # Yield each element of a given type ('row', 'c', etc.) to caller
     def each_element(path, elements)
+      elements = Array(elements)
       Nokogiri::XML::Reader(::File.open(path, 'rb'), nil, nil, Nokogiri::XML::ParseOptions::NOBLANKS).each do |node|
-        next unless node.node_type == Nokogiri::XML::Reader::TYPE_ELEMENT && Array(elements).include?(node.name)
+        next unless node.node_type == Nokogiri::XML::Reader::TYPE_ELEMENT && elements.include?(node.name)
         yield Nokogiri::XML(node.outer_xml).root if block_given?
       end
     end