Skip to content

Commit

Permalink
Merge pull request #620 from HashNotAdam/explicitly_define_mutable_st…
Browse files Browse the repository at this point in the history
…rings

Explicitly define mutable strings
  • Loading branch information
simonoff authored Feb 8, 2025
2 parents 02f5e4b + ec0fff8 commit fa6f21e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/roo/formatters/yaml.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def to_yaml(prefix = {}, from_row = nil, from_column = nil, to_row = nil, to_col
from_column ||= first_column(sheet)
to_column ||= last_column(sheet)

result = "--- \n"
result = String.new("--- \n")
from_row.upto(to_row) do |row|
from_column.upto(to_column) do |col|
next if empty?(row, col, sheet)
Expand Down
2 changes: 1 addition & 1 deletion test/roo/test_open_office.rb
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ def test_bug_ric
assert workbook.empty?("C", 1)
assert workbook.empty?("D", 1)
expected = 1
letter = "e"
letter = String.new("e")
while letter <= "u"
assert_equal expected, workbook.cell(letter, 1)
letter.succ!
Expand Down

0 comments on commit fa6f21e

Please sign in to comment.