I pulled down #set to GenericSpreedSheet #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def set_type(row,col,type,sheet=nil) | ||
| sheet = @default_value unless sheet | ||
| key = "#{row},#{col}" | ||
| @cell_type[sheet][[key]] = type |
There was a problem hiding this comment.
I think this extra [] around key is a bug.
|
Thanks for the pull request. It's good to have help for cleaning up this library. :-) |
|
@Empact, I added the deprecation warning you suggested and restore the original behavior for 'sheet' argument at #set, #set_value and #set_type. Do you think I also add a commit, for testing that behavior you mentioned for GenericSpreadsheet#set, where a nil value for the 'sheet' argument should be overridden by a default value even when an explicit nil is passed? |
stevendaniels
pushed a commit
that referenced
this pull request
Apr 15, 2016
get up-to-date with latest files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved #set, #set_value and #set_type from Excelx, Openoffice and Excel2003XML to GenericSpreedSheet, since they were identical at each subclass.