Expand merged cells to fill the range #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -121,10 +122,30 @@ def extract_hyperlinks(relationships) | |||
| end | |||
|
|
|||
| def extract_cells(relationships) | |||
| Hash[doc.xpath("/worksheet/sheetData/row/c").map do |cell_xml| | |||
| if @options[:expand_merged_cells] | |||
There was a problem hiding this comment.
Can you extract this block into separate method?
|
Would be great to have some test case for this new feature. |
1 similar comment
1 similar comment
|
Added tests with the option set and unset, and refactored out into a separate method. |
1 similar comment
|
Hey. Will this be usable with roo? |
|
It's usable from my fork, it's just pending integration. Simonoff would need to comment on that. |
|
Thanks. Working great. :) |
simonoff
added a commit
that referenced
this pull request
Mar 23, 2015
Expand merged cells to fill the range
|
I think we should update the README file too and document the new :expand_merged_ranges option. Along the same lines, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading a worksheet with merged cells the default behaviour is to have the value in the top left cell and the remaining cells be empty. Being able to expand the merged cells to duplicate the value into all cells in the range can be helpful.