Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix :parse method with :clean option #184

Merged
merged 1 commit into from
Mar 23, 2015
Merged

Fix :parse method with :clean option #184

merged 1 commit into from
Mar 23, 2015

Conversation

stevendaniels
Copy link
Contributor

  • Fixes Roo::Excelx.parse method when using :clean option
  • Fixes Roo::CSV.parse method when using :clean option
  • Added tests for parse with :clean option

@stevendaniels
Fix :parse method with :clean option
c007842 
 - Fixes Roo::Excelx.parse method when using :clean option
 - Fixes Roo::CSV.parse method when using :clean option
 - Added tests for parse with :clean option

fixed space
@stevendaniels
Copy link
Contributor Author

See #182 and #183

@coveralls
Copy link

Coverage Status

Coverage increased (+0.49%) to 93.17% when pulling c007842 on stevendaniels:error-parsing-with-clean into 707ed15 on roo-rb:master.

@stevendaniels
Copy link
Contributor Author

Travis failed because of a timeout, not because of a test case failing.

@reshleman
Copy link
Contributor

@stevendaniels Thanks for taking this on. I just pulled down your branch and did a quick smoke test in irb, and this does appear to resolve #182 and resolve #183.

Thanks for your contributions to this gem! 👍

@simonoff
Copy link
Member

@stevendaniels can you fix JRuby?

@simonoff
Copy link
Member

Oh... sorry, nevermind

simonoff added a commit that referenced this pull request Mar 23, 2015
@simonoff
Merge pull request #184 from stevendaniels/error-parsing-with-clean
4cce70a 
Fix :parse method with :clean option
@simonoff simonoff merged commit 4cce70a into roo-rb:master Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevendaniels @coveralls @reshleman @simonoff