Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #75 allow Roo::Excelx to open streams #209

Merged
merged 1 commit into from
May 7, 2015
Merged

Fixes #75 allow Roo::Excelx to open streams #209

merged 1 commit into from
May 7, 2015
+46 −15

Conversation

afn
Copy link
Contributor

@afn afn commented May 1, 2015

e.g.

stream = StringIO.new(excel_file_contents)
sheet = Roo::Spreadsheet.open stream, extension: :xlsx

@afn
Copy link
Contributor Author

afn commented May 1, 2015

fixes #75

@coveralls
Copy link

Coverage Status

Coverage increased (+0.11%) to 93.75% when pulling 3c0dda4 on amitree:open_streams into e7216e2 on roo-rb:master.

@PikachuEXE
Copy link

Got merge conflicts

@afn afn force-pushed the open_streams branch from 0334db2 to f411c07 Compare May 4, 2015 21:18
@coveralls
Copy link

Coverage Status

Coverage increased (+0.11%) to 93.74% when pulling f411c07 on amitree:open_streams into 38d708d on roo-rb:master.

simonoff added a commit that referenced this pull request May 7, 2015
@simonoff
Merge pull request #209 from amitree/open_streams
63b88c2 
Fixes #75 allow Roo::Excelx to open streams
@simonoff simonoff merged commit 63b88c2 into roo-rb:master May 7, 2015
@afn afn mentioned this pull request Jun 2, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afn @coveralls @PikachuEXE @simonoff