cell_to_csv for double quote escaping changed all tr to gsub #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tr is not escaping double quote characters correctly, replaced with call to gsub.
|
Thanks. Could you add a test for a properly formatted csv file with quotes in a field? test/test_generic_spreadsheet.rb has some related tests / data that you can work from. |
|
Hi Steven, Yes I will write the test as soon as I have some time in the next few days. Cheers On Mon, May 4, 2015 at 3:05 PM, Steven Daniels notifications@github.com
Cheers |
|
👍 It solves my problem with quotes inside cell |
|
Thanks. Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this issue :
#158
In cell_to_csv tr is not escaping double quote characters correctly, replaced with call to gsub.