Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid encoding error for CSV #372

Merged
merged 2 commits into from
Jan 4, 2017
Merged

Conversation

stevendaniels
Copy link
Contributor

Should fix #371

@coveralls
Copy link

coveralls commented Jan 3, 2017

Coverage Status

Changes Unknown when pulling 5cf03d7 on fix_iso_8599_1_csv_issue into ** on master**.

@coveralls
Copy link

coveralls commented Jan 4, 2017

Coverage Status

Changes Unknown when pulling 78fbefc on fix_iso_8599_1_csv_issue into ** on master**.

@stevendaniels stevendaniels merged commit 6c83f5d into master Jan 4, 2017
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Jan 8, 2017
## [2.7.1] 2017-01-03
### Fixed
- Fixed regression where a CSV's encoding was being ignored [372](roo-rb/roo#372)

## [2.7.0] 2016-12-31
### Fixed
- Added rack server for testing Roo's download capabilities [365](roo-rb/roo#365)
- Refactored tests into different formats [365](roo-rb/roo#365)
- Fixed OpenOffice for JRuby [362](roo-rb/roo#362)
- Added '0.000000' => '%.6f' number format [354](roo-rb/roo#354)
- Add additional formula cell types for to_csv [367][roo-rb/roo#367]

### Added
- Extracted formatters from Roo::Base#to_* methods [364](roo-rb/roo#364)

## [2.6.0] 2016-12-28
### Fixed
- Fixed error if sheet name starts with a slash [348](roo-rb/roo#348)
- Fixed loading to support files on ftp [355](roo-rb/roo#355)
- Fixed Ruby 2.4.0 deprecation warnings [356](roo-rb/roo#356)
- properly return date as string [359](roo-rb/roo#359)

### Added
- Cell values can be set in a CSV [350](roo-rb/roo#350)
- Raise an error Roo::Excelx::Extractor document is missing [358](roo-rb/roo#358)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encoding error with csv since 2.7.0
2 participants