Disable html injection

[welguisz]

From the initial pull request on HTML importing

Comment on Disable HTML,

this is an attempt to add the ability to disable HTML injection.

To disable, the desired function would be:

Roo::Excelx.new(path, disable_html_wrapper: true)

[coveralls]

Coverage increased (+0.02%) to 92.352% when pulling ae2cb13 on welguisz:option-off-html-strings into 6bde858 on roo-rb:master.

[edslocomb]

Is there anything blocking this PR?

We've been holding roo down to v2.3.2 for quite a while now due to problems caused by HTML injection in our importers, and we're getting a lot of deprecation warnings from ruby 2.4.1 in our tests.

[welguisz]

@edslocomb ... It is up to @stevendaniels to merge this pull request. I think that my tests and code is good. Don't know what else to do.

[edslocomb]

OK, it looks like this gem is not actively maintained.

For those who are experiencing bugs related to this, want to use the most recent version, and don't mind a monkeypatch to disable roo's html injection, try this:

module Roo                                                                                                                                                                                                                             
  class Excelx                                                                                                                                                                                                                         
    class SharedStrings < Excelx::Extractor                                                                                                                                                                                            
      def use_html?(_index)                                                                                                                                                                                                            
        false                                                                                                                                                                                                                          
      end                                                                                                                                                                                                                              
    end                                                                                                                                                                                                                                
  end                                                                                                                                                                                                                                  
end

for a Rails project, I suggest putting it in config/initializers/roo.rb

[cdlb-og]

NOTE: The actually-implemented option is called disable_html_wrapper not disable_html_injection
USAGE:
Roo::Excelx.new(path, disable_html_wrapper: true)

[Empact]

Thanks @cdlb-og, I've updated the OP.