Fixes issue where the contents of hidden sheet was returned when parsing visible sheets only. #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing visible sheets only.
simonoff
requested changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With
only_visible_sheetsoption set totrue, the contents of visible sheets were sometimes incorrect due to the index that was being provided to theSheetconstructor. This PR fixes that issue by keeping track of the indicies for the sheets that are kept and passing the appropriate index to the constructor.Other Information
I've updated the hidden_sheet.xlsx file to contain simple, identifying contents for both the hidden and visible sheets. I've also added a test that failed before the code change, but there may be a better location for that test.