Nokogiri hangs with large files #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l searches with exact root searches in read_shared_strings and read_cells. I also had to remove namespaces from that docs cause xpath was not findind the nodes. See original commit at d4a8e6f779e38c113967f944869dd45f498e4388
|
@zenzei I merged and extended your changes. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Empact.
Some (long) time ago you pull into your fork one modification I made for large files that were hanging with nokogiri, and you made a little update regarding namespaces to it (d4a8e6f779e38c113967f944869dd45f498e4388).
Today I decide to change my version and use your fork that looks a lot more updated (congratulations!). But when trying to process the same large files, the process hangs again.
So I decide to put my original lines in your version (in both methods, read_cells and read_shared_strings), and the code start to work again.
Unfortunately I can't upload the files because has private data, but is a file with 300.000 rows and 3 columns. In each row; the first cell has an average of 30 chars, the second one 11 chars, and in the last one, only 1 char.
Is not very clear to me why is this happening, and although I already update my fork with your changes and my fix, but it would be great if you can consider that modification cause i prefer to use your version that is by far more complete :)