Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/open office gsub replacement #581

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Fix/open office gsub replacement #581

merged 3 commits into from
Feb 6, 2023

Conversation

patrickkulling
Copy link
Contributor

@patrickkulling patrickkulling commented Jan 25, 2023 •
edited
Loading

Summary

Resolves #509

@kakubin could you prioritize this fix please?

kakubin
kakubin approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@kakubin kakubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for being late :(
It looks good to me to be declarative for what each of these are testing.

@patrickkulling patrickkulling merged commit 18b2e26 into roo-rb:master Feb 6, 2023
@patrickkulling patrickkulling deleted the fix/open-office-gsub-replacement branch February 6, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakubin kakubin kakubin approved these changes

Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can't modify frozen String (FrozenError) in open_office.rb
2 participants
@patrickkulling @kakubin