Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csv to gemspec #609

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add csv to gemspec #609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions roo.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Gem::Specification.new do |spec|
spec.required_ruby_version = ">= 2.7.0"
end

spec.add_dependency 'csv', '~> 3'
Copy link

@taketo1113 taketo1113 Sep 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyundso It seems it needs to add dependency of base64.

The base64 gem warn same message, warning message details is following:

/path/roo/lib/roo.rb:9: warning: base64 was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.
You can add base64 to your Gemfile or gemspec to silence this warning.
Suggested change
spec.add_dependency 'csv', '~> 3'
spec.add_dependency 'base64'
spec.add_dependency 'csv', '~> 3'

spec.add_dependency 'nokogiri', '~> 1'
spec.add_dependency 'rubyzip', '>= 1.3.0', '< 3.0.0'

Expand Down