[gh-2295] support bitcoin multisig address #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
jolestar
reviewed
Jul 29, 2024
Comment on lines
10
to
11
| [.new.base, "parse.base", 1000 * MUL], | ||
| [.new.per_byte, "parse.per_byte", 30 * MUL], |
There was a problem hiding this comment.
原来的 gas config 名称写错了，但不能删除。删除会有兼容性问题。可以把原来的保留，直接新增 parse gas config。
另外新增的 gas config 必须是 optional 模式，这样才能兼容。
There was a problem hiding this comment.
可以参考一下这个 PR 里面的写法 #1892
文件 frameworks/bitcoin-move/src/natives/ord/mod.rs 里面的代码可以参考。
有问题可以在 Discord 讨论。
There was a problem hiding this comment.
Create another issue and resolve in that issue.
feliciss
changed the title
1 task
jolestar
reviewed
Jul 30, 2024
Comment on lines
10
to
15
| [.verify_bitcoin_address_with_public_key.base, "verify_bitcoin_address_with_public_key.base", 1000 * MUL], | ||
| [.verify_bitcoin_address_with_public_key.per_byte, "verify_bitcoin_address_with_public_key.per_byte", 30 * MUL], | ||
| [.derive_multisig_xonly_pubkey_from_xonly_pubkeys.base, "derive_multisig_xonly_pubkey_from_xonly_pubkeys.base", 1000 * MUL], | ||
| [.derive_multisig_xonly_pubkey_from_xonly_pubkeys.per_byte, "derive_multisig_xonly_pubkey_from_xonly_pubkeys.per_byte", 30 * MUL], | ||
| [.derive_bitcoin_taproot_address_from_multisig_xonly_pubkey.base, "derive_bitcoin_taproot_address_from_multisig_xonly_pubkey.base", 1000 * MUL], | ||
| [.derive_bitcoin_taproot_address_from_multisig_xonly_pubkey.per_byte, "derive_bitcoin_taproot_address_from_multisig_xonly_pubkey.per_byte", 30 * MUL], |
There was a problem hiding this comment.
这些 gas config 也必须是 optional 的
There was a problem hiding this comment.
Others have to be handled at #2312.
jolestar
reviewed
Jul 31, 2024
Comment on lines
17
to
22
| const E_INVALID_ADDRESS: u64 = 1; | ||
| const E_ARG_NOT_VECTOR_U8: u64 = 2; | ||
| const E_INVALID_PUBLIC_KEY: u64 = 3; | ||
| const E_INVALID_THRESHOLD: u64 = 4; | ||
| const E_INVALID_KEY_EGG_CONTEXT: u64 = 5; | ||
| const E_INVALID_XONLY_PUBKEY: u64 = 6; |
| /// Parse the Bitcoin address string bytes to Move BitcoinAddress | ||
| native fun parse(raw_addr: &vector<u8>): BitcoinAddress; | ||
| native fun verify_with_pk (addr: &vector<u8>, pk: &vector<u8>): bool; |
There was a problem hiding this comment.
原有的方法不能变，不然无法升级，需要通过新增方法解决。
feliciss
force-pushed
the
#2295
branch
2 times, most recently
from
6e95ff4
to
394ca1e
Compare
added 8 commits
July 31, 2024 23:38
…eys and derive_bitcoin_taproot_address_from_multisig_xonly_pubkey.
jolestar
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support multisig address and refactor current address verification with public key.
Use MuSig2: https://conduition.io/code/musig2-crate/;
Crate: https://docs.rs/musig2/latest/musig2/;
Compatible with BIP-327 and BIP-340: https://github.com/bitcoin/bips/blob/master/bip-0327.mediawiki, https://github.com/bitcoin/bips/blob/master/bip-0340.mediawiki.
Closes [Framework] Native function support deriving multi-sign address #2295