🔨 Remove Pagination's default property herf #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlyrthiia
requested review from
wow-sven,
TwilightLogic and
Mine77
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CustomPagination Adding a default herf will cause the page to make meaningless jumps as well as add # hash to the url, greatly affecting the user experience.
Screen.Recording.2024-07-29.at.16.18.42.mov
Screen.Recording.2024-07-29.at.16.19.36.mov
Affects components:
The default herf=# in the test impact component is meaningless and affects the experience, if you need to jump links you can customize the herf separately in the prop.