Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨Issues #2248 fix transaction pages #2309

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

nlyrthiia
Copy link
Contributor

@nlyrthiia nlyrthiia commented Jul 29, 2024

Summary

fix issues: #2248

  1. Transactions with too many page numbers will lead to abnormal display, both pc and mobile will be abnormal, greatly affecting the user experience.
  2. When there is no page number, the default display will also show the ellipsis.
  3. Previous will be displayed on the first page.

rooch1

rooch2

Update

  • Hide Previous button if it is the first page, hide Next button if it is the last page.
  • Fix page number display, if there are too many page numbers, use ...... Omit the middle part
  • User can modify the number of pages displayed on a single page directly
  • The current strategy is defalut liimt to 10000000 to get all data, we need to provide new query api to support querying all data of transactions, and add HasPrevious data in result.

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 0:00am
rooch-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 0:00am

@jolestar jolestar merged commit 15b7e72 into rooch-network:main Aug 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants